Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spending of unconfirmed BSQ change outputs #2482

Refactor: Rename onParseTxsComplete to onParseBlockComplete

  • Loading branch information...
ManfredKarrer committed Mar 3, 2019
commit 8d73308796eba98b93c0a1efca7f6b3a9384b55b
@@ -153,7 +153,7 @@ public void start() {
///////////////////////////////////////////////////////////////////////////////////////////

@Override
public void onParseTxsComplete(Block block) {
public void onParseBlockComplete(Block block) {
maybeCalculateVoteResult(block.getHeight());
}

@@ -27,7 +27,7 @@ default void onParseBlockChainComplete() {
}

// Called before onParseTxsCompleteAfterBatchProcessing in case batch processing is complete
default void onParseTxsComplete(Block block) {
default void onParseBlockComplete(Block block) {
}

default void onParseTxsCompleteAfterBatchProcessing(Block block) {
@@ -216,7 +216,7 @@ public void onParseBlockComplete(Block block) {
// so we need to make sure that vote result calculation is completed before (e.g. for comp. request to
// update balance).
// TODO the dependency on ordering is nto good here.... Listeners should not depend on order of execution.
daoStateListeners.forEach(l -> l.onParseTxsComplete(block));
daoStateListeners.forEach(l -> l.onParseBlockComplete(block));

// We use 2 different handlers as we don't want to update domain listeners during batch processing of all
// blocks as that cause performance issues. In earlier versions when we updated at each block it took
@@ -73,7 +73,7 @@ public DaoStateSnapshotService(DaoStateService daoStateService,
// We listen to each ParseTxsComplete event even if the batch processing of all blocks at startup is not completed
// as we need to write snapshots during that batch processing.
@Override
public void onParseTxsComplete(Block block) {
public void onParseBlockComplete(Block block) {
int chainHeight = block.getHeight();

// Either we don't have a snapshot candidate yet, or if we have one the height at that snapshot candidate must be
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.