Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add altcoin payment method for live trading #2490

Merged
merged 8 commits into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

ManfredKarrer commented Mar 3, 2019

  • Add LiveAsset account, payment method, AccountPayload
  • Extract super classes for normal CryptoCurrenyAccount and payload and
    LiveAssetAccount and payload
  • Add isAsset method
  • Add button for creating a live asset account

As it is a bit tricky to use the AccountForm for both methods and add a
checkbox there so defined which payment method to use I added a button
to add an AccountForm with the LiveAssets passed. This is just
temporary to be able to test a bit more and see if there are any
critical issues. We should unify that form but that might require a bit
of refactoring of the CryptoCurrencyForm.

Add altcoin payment method for live trading
- Add LiveAsset account, payment method, AccountPayload
- Extract super classes for normal CryptoCurrenyAccount and payload and
LiveAssetAccount and payload
- Add isAsset method
- Add button for creating a live asset account

As it is a bit tricky to use the AccountForm for both methods and add a
checkbox there so defined which payment method to use I added a button
to add an AccountForm with the LiveAssets passed. This is just
temporary to be able to test a bit more and see if there are any
critical issues. We should unify that form but that might require a bit
of refactoring of the CryptoCurrencyForm.

@ManfredKarrer ManfredKarrer requested a review from ripcurlx Mar 3, 2019

ManfredKarrer added some commits Mar 3, 2019

ManfredKarrer added some commits Mar 4, 2019

@ManfredKarrer ManfredKarrer marked this pull request as ready for review Mar 4, 2019

@ManfredKarrer ManfredKarrer requested a review from devinbileck Mar 4, 2019

@ripcurlx ripcurlx self-requested a review Mar 4, 2019

@ripcurlx
Copy link
Member

ripcurlx left a comment

ACK - Besides my suggested text change.

ManfredKarrer added some commits Mar 4, 2019

@ManfredKarrer ManfredKarrer merged commit 804f8e9 into bisq-network:master Mar 4, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:add-live-trading branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.