Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vote result json deterministic #2515

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

commented Mar 7, 2019

No description provided.

@ManfredKarrer ManfredKarrer requested a review from ripcurlx as a code owner Mar 7, 2019

@ManfredKarrer ManfredKarrer requested a review from ben-kaufman Mar 7, 2019

@ManfredKarrer ManfredKarrer added the in:dao label Mar 8, 2019

@ManfredKarrer ManfredKarrer added this to the v0.9.6 milestone Mar 8, 2019

});
cycleJson.addProperty("numberOfProposals", proposalsArray.size());

This comment has been minimized.

Copy link
@ben-kaufman

ben-kaufman Mar 8, 2019

Contributor

This seems to be a duplicate of proposalsCount. Please remove one of them.
If you keep this one, I suggest to also change the name of votesCount to numberOfVotes and make it an int to keep consistency.

This comment has been minimized.

Copy link
@ManfredKarrer

ManfredKarrer Mar 8, 2019

Author Member

Ah thanks! Fixed. Can you ass ACK or utACK if it si now ok from your side

@ben-kaufman
Copy link
Contributor

left a comment

ACK

@ManfredKarrer ManfredKarrer merged commit 257550a into bisq-network:master Mar 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:make-vote-result-json-determinisitic branch Mar 18, 2019

@ben-kaufman ben-kaufman referenced this pull request Mar 29, 2019

Closed

For March 2019 #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.