Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feedback popup for DAO test users #2521

Merged
merged 3 commits into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@ben-kaufman
Copy link
Contributor

commented Mar 10, 2019

Fix #2485

I was still unable to properly test the activation of the popup as I'm still setting up my local environment.
This should launch the popup if the user voted or submitted a proposal in the last cycle.

Screen Shot 2019-03-10 at 21 47 31

@ManfredKarrer ManfredKarrer added this to the v0.9.6 milestone Mar 10, 2019

@m52go

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

This is great...thanks Ben, glad to have this in the next release.

I find the proposed text a little wordy, and also think we should mention the BSQ bounty for doing the feedback survey. The text should be as concise as possible to maximize survey clicks.

Here is what I suggest.


Thank you for testing the Bisq DAO

Can you spare 3 minutes to do a quick survey? We're offering 20 BSQ for completed surveys.

Your feedback is crucial to ensuring a smooth launch on mainnet.

Do survey >

Questions, or other issues? Discuss with Bisq users and contributors on the forum:

Visit forum >

@ManfredKarrer ManfredKarrer requested review from m52go and removed request for ripcurlx Mar 11, 2019

String testingPopupKey = "daoTestingFeedbackPopup";
if (DontShowAgainLookup.showAgain(testingPopupKey)) {
UserThread.runAfter(() -> {
if (sortedList.size() > 0 && sortedList.stream().map(proposalsListItem -> proposalsListItem.getProposal().getTxId())

This comment has been minimized.

Copy link
@ManfredKarrer

ManfredKarrer Mar 11, 2019

Member

Better to use myProposalListService.getList()' - this gives you your own proposals and test with periodService.isTxInCorrectCycle(tx.getBlockHeight(), daoStateService.getChainHeight())` if it the proposal is in the current cycle.

@@ -203,6 +209,8 @@ protected void activate() {

sortedList.comparatorProperty().bind(tableView.comparatorProperty());

maybeShowDAOTestingFeedbackWindow();

This comment has been minimized.

Copy link
@ManfredKarrer

ManfredKarrer Mar 11, 2019

Member

Seems that would show the popup after the user has made a proposal. We want to show the popup only after the voting phase in case the user has created a proposal or if he has voted. Sorry that I have not been more clear in the GH issue....

if (DontShowAgainLookup.showAgain(testingPopupKey)) {
UserThread.runAfter(() -> {
if (sortedCycleListItemList.size() > 0 && (sortedCycleListItemList.get(0).getResultsOfCycle().getEvaluatedProposals().stream().map(EvaluatedProposal::getProposalTxId)
.flatMap(key -> bsqWalletService.getWalletTransactions().stream().map(Transaction::getHashAsString)

This comment has been minimized.

Copy link
@ManfredKarrer

ManfredKarrer Mar 11, 2019

Member

I would prefer here also to use the DAO domain instead the BTC domain to avoid too much dependency to the wallet.
MyBlindVoteListService holds your own blind votes and with a check for the cycle you see if it is a current vote.

daoTestingFeedbackWindow.title=Thank you for testing the Bisq DAO
daoTestingFeedbackWindow.msg.part1=Can you spare 3 minutes to do a quick survey? We're offering 20 BSQ for completed surveys.\
\nYour feedback is crucial to ensuring a smooth launch on mainnet.
daoTestingFeedbackWindow.surveyLinkLabel=Do survey >

This comment has been minimized.

Copy link
@ManfredKarrer

ManfredKarrer Mar 11, 2019

Member

Maybe remove the >

\nYour feedback is crucial to ensuring a smooth launch on mainnet.
daoTestingFeedbackWindow.surveyLinkLabel=Do survey >
daoTestingFeedbackWindow.msg.part2=Questions, or other issues? Discuss with Bisq users and contributors on the forum:
daoTestingFeedbackWindow.forumLinkLabel=Visit forum >

This comment has been minimized.

Copy link
@ManfredKarrer

ManfredKarrer Mar 11, 2019

Member

Maybe remove the >

@ben-kaufman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

@ManfredKarrer I fixed according to your comments, hopefully, should be good this time :)

@m52go

m52go approved these changes Mar 11, 2019

Copy link
Member

left a comment

For the record, this approval is just for the text (haven't tested the actual pop-up).

@ManfredKarrer
Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit cdce61c into bisq-network:master Mar 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ben-kaufman ben-kaufman referenced this pull request Mar 29, 2019

Closed

For March 2019 #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.