Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve restore wallet from seed process #2524

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

commented Mar 11, 2019

No description provided.

ManfredKarrer added some commits Mar 11, 2019

Replace addTransactionConfidenceEventListener
Use addCoinsReceivedEventListener and addCoinsSentEventListener instead
of addTransactionConfidenceEventListener as
addTransactionConfidenceEventListener has much more overhead.
I could not reproduce anymore the balance issues I had when I used that
approach during development earlier.

@ManfredKarrer ManfredKarrer requested a review from oscarguindzberg Mar 11, 2019

@ManfredKarrer ManfredKarrer requested a review from ripcurlx as a code owner Mar 11, 2019

@oscarguindzberg

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

utACK

@ManfredKarrer ManfredKarrer merged commit c00cf99 into bisq-network:master Mar 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@oscarguindzberg oscarguindzberg referenced this pull request Mar 29, 2019

Closed

For March 2019 #250

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:improve-restore-wallet-from-seed-process branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.