Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug UI treats rejected proposals as accepted #2528

Merged

Conversation

Projects
None yet
2 participants
@ben-kaufman
Copy link
Contributor

commented Mar 11, 2019

This fixes #2479, fixes #2480.

The issue was that the function returned a list of all proposals from the requested type, without filtering out the rejected proposals.
I added filtering to make sure it returns only accepted proposals.

ben-kaufman added some commits Mar 11, 2019

Get only accepted remove asset proposals
Fix rejected remove asset proposals showing as accepted
Get only accepted bonded role proposals
Fix rejected bonded role proposal showing as accepted

@ben-kaufman ben-kaufman requested a review from ManfredKarrer as a code owner Mar 11, 2019

@ManfredKarrer ManfredKarrer added this to the v0.9.6 milestone Mar 11, 2019

@ManfredKarrer
Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 76543bb into bisq-network:master Mar 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ben-kaufman ben-kaufman deleted the ben-kaufman:get-only-accepted-proposals branch Mar 28, 2019

@ben-kaufman ben-kaufman referenced this pull request Mar 29, 2019

Closed

For March 2019 #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.