Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress popup at shutdown when open offers are disabled #2569

Conversation

Projects
None yet
2 participants
@devinbileck
Copy link
Member

commented Mar 22, 2019

Issue: When shutting down the application with disabled open offers, the
confirmation popup was still being shown informing the user there are
open offers.

Fix: On shutdown, check all open offers and only show the popup if any
of them are enabled.

Fixes #2115

Suppress popup at shutdown when open offers are disabled
Issue: When shutting down the application with disabled open offers, the
confirmation popup was still being shown informing the user there are
open offers.

Fix: On shutdown, check all open offers and only show the popup if any
of them are enabled.

Fixes #2115
@ManfredKarrer
Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 133db94 into bisq-network:master Mar 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:suppress-popup-at-shutdown-when-open-offers-are-disabled branch Mar 22, 2019

@devinbileck devinbileck referenced this pull request Mar 26, 2019

Closed

For March 2019 #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.