Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max buyer's security deposit to 20% instead of 10% #2575

Merged

Conversation

Projects
None yet
3 participants
@ManfredKarrer
Copy link
Member

commented Mar 23, 2019

A Bisq trader suggested that change to cover risks with volatility
for seller.

@ManfredKarrer ManfredKarrer requested review from ripcurlx and devinbileck Mar 23, 2019

@ManfredKarrer ManfredKarrer added this to the v0.9.6 milestone Mar 23, 2019

@ManfredKarrer ManfredKarrer self-assigned this Mar 23, 2019

@devinbileck
Copy link
Member

left a comment

utACK
Just a minor nit about the comment.

Set max buyer's security deposit to 20% instead of 10%
A Bisq trader suggested that change to cover risks with volatility
for seller.

@ripcurlx ripcurlx force-pushed the ManfredKarrer:higher-max-buyer-security-deposit branch from ce6477e to 100d838 Mar 25, 2019

@ripcurlx

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

@ManfredKarrer Sorry for taking over your commit 😉 . I just made the change @devinbileck was requesting and didn't want to create another commit message.

@ripcurlx
Copy link
Member

left a comment

ACK

@ripcurlx ripcurlx merged commit ab4d203 into bisq-network:master Mar 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:higher-max-buyer-security-deposit branch Mar 25, 2019

@devinbileck devinbileck referenced this pull request Mar 26, 2019

Closed

For March 2019 #244

@ripcurlx ripcurlx referenced this pull request Mar 28, 2019

Closed

For March 2019 #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.