Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISSUANCE_LIMIT param and check for max issuance per cycle #2584

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

commented Mar 25, 2019

We limit the possible max. issuance (including reimbursements) to the
valued defined in the ISSUANCE_LIMIT param.
In case we exceed that limit the whole cycle becomes invalid.

The main reason for that feature is limitation of max.
damage in case that an attacker manages to create unjustified issuance.

For valid cases we consider such a case as social consensus problem as
the majority of voters should be aware of that limit before they
accept such a high issuance. If known in advance that an extraordinary
high issuance is expected the DAO parameter can be changed.

Add ISSUANCE_LIMIT param and check for max issuance per cycle
We limit the possible max. issuance (including reimbursements) to the
valued defined in the ISSUANCE_LIMIT param.
In case we exceed that limit the whole cycle becomes invalid.

The main reason for that feature is limitation of max.
damage in case that an attacker manages to create unjustified issuance.

For valid cases we consider such a case as social consensus problem as
the majority of voters should be aware of that limit before they
accept such a high issuance. If known in advance that an extraordinary
high issuance is expected the DAO parameter can be changed.

@ManfredKarrer ManfredKarrer requested review from ripcurlx and sqrrm Mar 25, 2019

@sqrrm

sqrrm approved these changes Mar 25, 2019

Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 15bf8ff into bisq-network:master Mar 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:add-issuance-limit branch Mar 25, 2019

@sqrrm sqrrm referenced this pull request Mar 30, 2019

Closed

For March 2019 #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.