Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show close button when creating offer without required account #2590

Conversation

Projects
None yet
2 participants
@devinbileck
Copy link
Member

commented Mar 26, 2019

Issue: When attempting to create an offer without a trading account for
the selected currency, a prompt is shown asking the user whether to still
create an offer or to create a new account. But this prompt is missing a
cancel/close button in case you don't want to do either action. And
pressing Esc on the keyboard proceeds to create the account.
image

Cause: The close button on the prompt was renamed and being used to
create a new account.

Fix: Use the close button as a close button and add a secondary action
button to create a new account. The popup width was increased to
accommodate the long button text without being truncated.
image

Show close button when creating offer without required account
Issue: When attempting to create an offer without a trading account for
the selected currency, a prompt is shown asking the user whether to still
create an offer or to create a new account. But this prompt is missing a
cancel/close button in case you don't want to do either action. And
pressing Esc on the keyboard proceeds to create the account.

Cause: The close button on the prompt was renamed and being used to
create a new account.

Fix: Use the close button as a close button and add a secondary action
button to create a new account. The popup width was increased to
accommodate the long button text without being truncated.

@devinbileck devinbileck referenced this pull request Mar 26, 2019

Closed

For March 2019 #244

@ManfredKarrer
Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 55c5435 into bisq-network:master Mar 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:no-trading-account-for-selected-currency branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.