Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing check for mandatory bsq output #2614

Conversation

Projects
None yet
4 participants
@ManfredKarrer
Copy link
Member

commented Apr 2, 2019

@ripcurlx This is an important fix which should be included in the release!

@sqrrm If you have time for a critical review would be great!

Fixes #2613

ManfredKarrer added some commits Apr 2, 2019

Add check for mandatory BSQ output for compensation tx
Fixes #2613

If the user has the exact fee in his wallet no BSQ change output would
be created but that violates our requirement for compensation or
reimbursement txs.
Beside that the error message for dust outputs was not clear.

@ManfredKarrer ManfredKarrer requested review from ripcurlx, devinbileck and sqrrm Apr 2, 2019

@ManfredKarrer ManfredKarrer added this to the v0.9.6 milestone Apr 2, 2019

@ripcurlx
Copy link
Member

left a comment

utACK

@devinbileck
Copy link
Member

left a comment

ACK
Tested with no change output (2 BSQ available), and below minimum dust output (<7.46 BSQ available).

@ripcurlx ripcurlx merged commit 6e2aaec into bisq-network:master Apr 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sqrrm
Copy link
Member

left a comment

utACK

ManfredKarrer added a commit that referenced this pull request Apr 3, 2019

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:add-missing-check-for-mandatory-bsq-output branch Apr 4, 2019

@devinbileck devinbileck referenced this pull request May 4, 2019

Open

Cycle 1 #270

@sqrrm sqrrm referenced this pull request May 7, 2019

Open

Cycle 1 #282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.