Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect transaction size shown for bonding #2652

Merged

Conversation

Projects
None yet
2 participants
@devinbileck
Copy link
Member

commented Apr 5, 2019

When locking up or unlocking a bond, the displayed transaction size was
in bytes, but the prompt was indicating it was Kb. So adjust the value
so it is shown as Kb.

Before:
image

After:
image

Fix incorrect transaction size shown for bonding
When locking up or unlocking a bond, the displayed transaction size was
in bytes, but the prompt was indicating it was Kb. So adjust the value
so it is shown as Kb.
@ripcurlx
Copy link
Member

left a comment

utACK - Good catch 👍! I quickly checked the other places where we display Kb and it looks like it is correctly calculated everywhere else.

@ripcurlx ripcurlx merged commit de3a2ba into bisq-network:master Apr 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:fix-incorrect-txsize-for-bonding branch Apr 5, 2019

@devinbileck devinbileck referenced this pull request May 4, 2019

Open

Cycle 1 #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.