Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tx display for BTC withdrawal from BSQ wallet #2655

Conversation

Projects
None yet
2 participants
@ripcurlx
Copy link
Member

commented Apr 5, 2019

Fixes #2637.

Bildschirmfoto 2019-04-05 um 16 30 40

Bildschirmfoto 2019-04-05 um 16 30 20

ripcurlx added some commits Apr 5, 2019

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Apr 5, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Maybe the N/A could be changed here to 0?

@ripcurlx

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

Maybe the N/A could be changed here to 0?

Yes, would make sense. I'll update that.

@ManfredKarrer
Copy link
Member

left a comment

utACK

btcAmountInputTextField.setText("");
});

if (miningFee.getValue() > receiverAmount.getValue())

This comment has been minimized.

Copy link
@ManfredKarrer

ManfredKarrer Apr 5, 2019

Member

I think it should be >=

This comment has been minimized.

Copy link
@ManfredKarrer

ManfredKarrer Apr 5, 2019

Member

I think a check that the output is no below dust limit is in the wallet service, but maybe better to cross check?

This comment has been minimized.

Copy link
@ripcurlx

ripcurlx Apr 5, 2019

Author Member

Yes, we probably should already prevent it, if the amount will be 0 in the end. Maybe we should also prevent it already before, but there it is hard where to draw a line.

This comment has been minimized.

Copy link
@ripcurlx

ripcurlx Apr 5, 2019

Author Member

I think a check that the output is no below dust limit is in the wallet service, but maybe better to cross check?

There is a dust check in place already.

@ManfredKarrer
Copy link
Member

left a comment

See comment for small improvemet and double check dust limit, beside that utACK

btcAmountInputTextField.setText("");
});

if (miningFee.getValue() > receiverAmount.getValue())

This comment has been minimized.

Copy link
@ManfredKarrer

ManfredKarrer Apr 5, 2019

Member

I think a check that the output is no below dust limit is in the wallet service, but maybe better to cross check?

ripcurlx added some commits Apr 5, 2019

@ripcurlx ripcurlx merged commit 400fbbd into bisq-network:master Apr 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.