Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cryptographic hash from protobuffer serialized data instead of hashCode #2665

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
3 participants
@ManfredKarrer
Copy link
Member

commented Apr 7, 2019

Fixes #2662

Let's wait with merge until we are sure when we want to deploy it.

@ManfredKarrer ManfredKarrer changed the title Use cryptographic hash from protobuffer serialized data instead of ha… Use cryptographic hash from protobuffer serialized data instead of hashCode Apr 7, 2019

@ManfredKarrer ManfredKarrer requested a review from sqrrm Apr 7, 2019

@ManfredKarrer ManfredKarrer added the in:dao label Apr 7, 2019

@ManfredKarrer ManfredKarrer added this to the v0.9.8 milestone Apr 7, 2019

@sqrrm

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

I think it's worth getting this right. The change itself is simple and those that want to can upgrade testnet to get the monitoring right. Slightly annoying vs keeping this into live launch.

utACK

@ManfredKarrer ManfredKarrer marked this pull request as ready for review Apr 8, 2019

@ripcurlx
Copy link
Member

left a comment

utACK

@ripcurlx ripcurlx merged commit f4c65c4 into bisq-network:master Apr 8, 2019

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:use-crypt-hash-at-role branch Apr 8, 2019

@sqrrm sqrrm referenced this pull request May 7, 2019

Open

Cycle 1 #282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.