Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close printWriter before renaming temp file #2669

Conversation

Projects
None yet
3 participants
@ManfredKarrer
Copy link
Member

commented Apr 7, 2019

Fixes #2660

@ManfredKarrer ManfredKarrer requested a review from ripcurlx Apr 7, 2019

@ManfredKarrer ManfredKarrer added the in:dao label Apr 7, 2019

@ManfredKarrer ManfredKarrer added this to the v0.9.8 milestone Apr 7, 2019

@ManfredKarrer ManfredKarrer changed the title Fixes https://github.com/bisq-network/bisq/issues/2660 Close printWriter before renaming temp file Apr 7, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2019

@BrettCawley could you test on Windows if that fixes it? Assume so as your PR was doing the same at the end... sorry for not pushing it into your PR, just thought its easier that way....

@BrettCawley

This comment has been minimized.

Copy link

commented Apr 8, 2019

No worries... Tested and works!

@ripcurlx
Copy link
Member

left a comment

utACK

@ripcurlx ripcurlx merged commit 33a04bb into bisq-network:master Apr 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:close-printwriter-before-rename-temp-file branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.