Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DAO launch popup #2688

Merged
merged 6 commits into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@ripcurlx
Copy link
Member

commented Apr 10, 2019

Fixes #2632.

ripcurlx added some commits Apr 8, 2019

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Apr 10, 2019

@m52go

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Text suggestions:

popup.dao.launch.headline=The complete vision, realized

popup.dao.launch.trading=Trade BSQ (colored bitcoin) to participate in Bisq governance. You can buy and sell BSQ just like any other asset on Bisq.

For the cheaper fees string, my reworded version is a bit longer. I like it better, but if it's too long to fit in the space we have, we can just use the alternative.

//suggestion (maybe better, but too long?)
popup.dao.launch.cheaperFees=You pay Bisq contributors when you buy BSQ from them. You also get a 90% discount on trading fees by paying with BSQ.\nSave money & support the project by using BSQ!

//alternative (shorter)
popup.dao.launch.cheaperFees=Get a 90% discount on trading fees when you use BSQ. Save money and support the project at the same time!
@ManfredKarrer
Copy link
Member

left a comment

utACK

@ripcurlx

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

Updated it for trading
Bildschirmfoto 2019-04-10 um 16 27 22

For cheaper fees I needed to use the shorter variant:
Bildschirmfoto 2019-04-10 um 16 27 32
Bildschirmfoto 2019-04-10 um 16 30 03

@m52go

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Yeah I figured it would be too long. All good!

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

The version on top feels a bit strange to me. It does not fell to be part of the headline but then why its there....

@ripcurlx

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

The version on top feels a bit strange to me. It does not fell to be part of the headline but then why its there....

The version on top will be 1.0.0 in the release. It should emphasize the version 1.0. I just used the current version atm, so it also works if we decide in the end to go live with 1.0.1. But maybe it should just says static "Bisq v1.0" as in Pedro's design suggested.

Like that:
Bildschirmfoto 2019-04-10 um 16 43 23

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Screen Shot 2019-04-10 at 09 43 38

Screen Shot 2019-04-10 at 09 43 35

The green colors in the screenshots are a bit different as the app gree.

@ripcurlx

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

Screen Shot 2019-04-10 at 09 43 38 Screen Shot 2019-04-10 at 09 43 35

The green colors in the screenshots are a bit different as the app gree.

Hmm, true. I did screenshot it from the app, but I guess something went wrong during the export. I'll re-check the source files.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

For my taste the distance between text and screenshot is a bit too high in relation to other distances.
Maybe the arrows would be a bit closer as well.
I think if we use the version we should use it hard coded with 1.0 as if we need to push an update soon it will be weird (1.0.1 etc). But maybe we shoudl include it more in the headline. Like:
"Bisq 1.0 - The ...."

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Did you export to jpeg? I think we can keep it png then they are exact.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Do you think a sliding animation (left -> right) for the slides is lots of work? The hard cuts are a bit too hard IMO.
Alos maybe the background can be more darkened?

@ripcurlx

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

Did you export to jpeg? I think we can keep it png then they are exact.

I used png's already - I think it is the fade out that causes the issue in the "cheaper fees" screenshot.

@ripcurlx

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

I adapted the layout a little bit and changed the last screenshot (it was an optical effect when fading or overlaying with a gradient to white)
Bildschirmfoto 2019-04-10 um 17 35 41
Bildschirmfoto 2019-04-10 um 17 35 36

@ripcurlx

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

Do you think a sliding animation (left -> right) for the slides is lots of work? The hard cuts are a bit too hard IMO.
Alos maybe the background can be more darkened?

I'm not sure if I'm able to finish it today (I'm off soon). Let's see if I can squeeze in some transition animations.

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Should link go to DAO webpage or to docs? I think docs might fit better to learn more as DAO webpage is super high level

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

We can merge that and add the animation tomorrow...

@ripcurlx

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

Should link go to DAO webpage or to docs? I think docs might fit better to learn more as DAO webpage is super high level

You mean this link: https://docs.bisq.network/dao-user-reference.html?

@ManfredKarrer ManfredKarrer merged commit f551bd9 into bisq-network:master Apr 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.