Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve space management in button bar of overlays #2699

Merged

Conversation

Projects
None yet
2 participants
@ripcurlx
Copy link
Member

commented Apr 11, 2019

Fixes #2681.

ripcurlx added some commits Apr 11, 2019

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Apr 11, 2019

@ManfredKarrer
Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit d7195c4 into bisq-network:master Apr 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -127,8 +127,7 @@ protected void onShow() {
protected void addButtons() {
super.addButtons();

closeButton.setPrefWidth(162);
actionButton.setPrefWidth(162);
closeButton.prefWidthProperty().bind(actionButton.widthProperty());

This comment has been minimized.

Copy link
@ManfredKarrer

ManfredKarrer Apr 11, 2019

Member

Are you sure the setters are never called in any other popup? It would cause an error if binding is set and we call setWidth somewhere else....

Ah its not in the super class, so should be isolated then to that window.

utACK

This comment has been minimized.

Copy link
@ripcurlx

ripcurlx Apr 11, 2019

Author Member

Yes, it was just to have the same button width based on Pedro's design for this popup.

This comment has been minimized.

Copy link
@ripcurlx

ripcurlx Apr 11, 2019

Author Member

But still to support bigger button sizes for different languages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.