Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doichain: set p2shHeader. #2728

Merged

Conversation

Projects
None yet
2 participants
@oscarguindzberg
Copy link
Contributor

commented Apr 16, 2019

See https://github.com/Doichain/core/blob/master/src/chainparams.cpp#L181

Not setting the p2shHeader makes the p2shHeader to be 0, that has problems on address validation on bitcoinj 0.15

@ManfredKarrer
Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 487f714 into bisq-network:master Apr 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@oscarguindzberg oscarguindzberg referenced this pull request May 8, 2019

Open

Cycle 1 #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.