Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request blocks in case we have not received it #2730

Merged

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

commented Apr 17, 2019

Once we get a new block from BitcoinJ we start a timer and check in 10
seconds if we have received the block from the P2P network. If not we
request it from the seed nodes.

Request blocks in case we have not received it
Once we get a new block from BitcoinJ we start a timer and check in 10
seconds if we have received the block from the P2P network. If not we
request it from the seed nodes.

@ManfredKarrer ManfredKarrer added this to the v1.0.1 milestone Apr 17, 2019

@ManfredKarrer ManfredKarrer requested a review from sqrrm Apr 17, 2019

@ManfredKarrer ManfredKarrer modified the milestones: v1.0.1, v1.1.0 Apr 17, 2019

@sqrrm
Copy link
Member

left a comment

I think it would be better to ask for the first block we don't have rather than the last block we have.

@ManfredKarrer ManfredKarrer merged commit 2119872 into bisq-network:master Apr 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:request-block-if-not-received branch Apr 18, 2019

@sqrrm sqrrm referenced this pull request May 7, 2019

Open

Cycle 1 #282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.