Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeaddress and capabilities at getblocks request #2732

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

commented Apr 17, 2019

When we request at startup the blocks from a seed which has not yet
received out capabilities or node address we will not get a response.
We do not want to depend on the state in the getData domain in the
p2p network by using only a seed which has already responded but we
prefer to make sure the seednode will get all the data by our request
to be able to respond.

ManfredKarrer added some commits Apr 17, 2019

Make GetBlocksRequest implement SendersNodeAddressMessage and Support…
…edCapabilitiesMessage

When we request at startup the blocks from a seed which has not yet
received out capabilities or node address we will not get a response.
We do not want to depend on the state in the getData domain in the
p2p network by using only a seed which has already responded but we
prefer to make sure the seednode will get all the data by our request
to be able to respond.

@ManfredKarrer ManfredKarrer requested review from sqrrm and ripcurlx Apr 17, 2019

@ManfredKarrer ManfredKarrer added this to the v1.1.0 milestone Apr 17, 2019

@ManfredKarrer ManfredKarrer changed the title Add nodeaddress at getblocks request Add nodeaddress and capabilities at getblocks request Apr 17, 2019

@sqrrm

sqrrm approved these changes Apr 17, 2019

Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit bebb481 into bisq-network:master Apr 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:add-nodeaddress-at-getblocks-request branch Apr 17, 2019

@sqrrm sqrrm referenced this pull request May 7, 2019

Open

Cycle 1 #282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.