Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with DAO full mode in preferences #2736

Conversation

Projects
None yet
2 participants
@ManfredKarrer
Copy link
Member

commented Apr 17, 2019

There was missing the block notify port as well as the options have
not been applied correctly which led to the situation that when you
run the same application in full mode and later in lite mode that
data got persisted.

Added also to the footer a note if full mode is running.

Screen Shot 2019-04-17 at 18 26 50

Fix issues with DAO full mode in preferences
There was missing the block notify port as well as the options have
not been applied correctly which led to the situation that when you
run the same application in full mode and later in lite mode that
data got persisted.

Added also to the footer a note if full mode is running.

ManfredKarrer added some commits Apr 17, 2019

@ripcurlx
Copy link
Member

left a comment

ACK

@ripcurlx

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Only conflicts need to be resolved

ManfredKarrer added some commits Apr 20, 2019

Merge branch 'master' into fix-dao-full-mode-settings-issue
# Conflicts:
#	common/src/main/proto/pb.proto
#	core/src/main/java/bisq/core/user/Preferences.java
#	core/src/main/java/bisq/core/user/PreferencesPayload.java
#	desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java

@ManfredKarrer ManfredKarrer merged commit f36823f into bisq-network:master Apr 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:fix-dao-full-mode-settings-issue branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.