Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTF8 for getBytes calls #2737

Merged

Conversation

Projects
None yet
3 participants
@ManfredKarrer
Copy link
Member

commented Apr 18, 2019

Fixes #2729

@ManfredKarrer ManfredKarrer requested review from ripcurlx and devinbileck Apr 18, 2019

@ManfredKarrer ManfredKarrer requested a review from cbeams as a code owner Apr 18, 2019

@ManfredKarrer ManfredKarrer added the a:bug label Apr 18, 2019

@ManfredKarrer ManfredKarrer added this to the v1.1.0 milestone Apr 18, 2019

@ManfredKarrer

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

@devinbileck Would be great if you could test that on Windows with whole smoke test (trade) as I cahnged all ocurrances of getByte(). I tested on regtest and all worked.

@ManfredKarrer ManfredKarrer requested review from sqrrm and removed request for cbeams Apr 18, 2019

@ripcurlx
Copy link
Member

left a comment

ACK - Still works for me on macOS and tried it with the changed update message on Windows 10, which works as well.

@devinbileck

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

ACK. Works for me as well on regtest using Windows 10.

@devinbileck
Copy link
Member

left a comment

ACK

@ManfredKarrer

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

Has anyone tested notifiactions? Not sure if the change there could break something.

@devinbileck

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Yes, I tested alert notifications as well as private messages (via arbitration). And also used some random UTF-8 characters in the messages. Didn't encounter any issues.

@ManfredKarrer ManfredKarrer merged commit eb1c4fd into bisq-network:master Apr 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:use-utf8-for-getBytes branch Apr 21, 2019

@devinbileck devinbileck referenced this pull request May 4, 2019

Open

Cycle 1 #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.