Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of editing of offers with invalid security deposit #2740

Conversation

Projects
None yet
3 participants
@ripcurlx
Copy link
Member

commented Apr 18, 2019

Shows warning popup when offer with invalid security deposit is edited.
@m52go Could you please review the text? Thanks!
Bildschirmfoto 2019-04-18 um 13 19 24

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Apr 18, 2019

@ripcurlx ripcurlx requested a review from m52go Apr 18, 2019

@m52go

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Here is a general message:

The buyer's security deposit is not within the constraints defined by the Bisq DAO and can no longer be edited.

If this message will always be shown to the person making the edit, I would suggest simply saying:

Your security deposit is not within the constraints defined by the Bisq DAO and can no longer be edited.

@ripcurlx

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

Here is a general message:

The buyer's security deposit is not within the constraints defined by the Bisq DAO and can no longer be edited.

If this message will always be shown to the person making the edit, I would suggest simply saying:

Your security deposit is not within the constraints defined by the Bisq DAO and can no longer be edited.

It will always be the maker, but she can be the buyer or seller. So I'll go with the general message -thx!

@ripcurlx ripcurlx force-pushed the ripcurlx:handle-editing-of-offers-with-invalid-deposit branch from ba81b54 to 8481593 Apr 18, 2019

@ManfredKarrer
Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 2f44971 into bisq-network:master Apr 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@m52go m52go referenced this pull request May 9, 2019

Open

For Cycle 1 #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.