Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Use different security deposit for fiat-crypto and crypto-crypto trades #2742
Apr 18, 2019
I think this is mostly correct as far as I know, I'm not that familiar with the trade protocol though so I can't tell if there is some case where the deposit should be updated.
Also, see inline comments.
Thanks for the review. I force pushed all changes.
As a reviewer I prefer when the previous commits are kept and just add a new one rather than a force push. Easier to follow which changes were made after comments were made that way.
True - I wanted to reduce the amount of commits, but in a PR that gets reviewed it makes it harder to follow.