Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow seller to take any offers #2813

Merged

Conversation

Projects
None yet
3 participants
@ManfredKarrer
Copy link
Member

commented May 6, 2019

No description provided.

ManfredKarrer added some commits May 6, 2019

Fix bug that sellers are restricted as well
Only buyers should be restricted if their account age is too young.
Reduce SAFE_ACCOUNT_AGE_DATE from 15.3. to 1.3.
We have one very suspicious case where the trader created his
account on 15. of March. To be more safe to exclude potential scammers
we decrease the check to 1st of march.

@ManfredKarrer ManfredKarrer requested a review from ripcurlx as a code owner May 6, 2019

@ManfredKarrer ManfredKarrer requested review from sqrrm and devinbileck May 6, 2019

@sqrrm

sqrrm approved these changes May 6, 2019

Copy link
Member

left a comment

utACK

@ripcurlx
Copy link
Member

left a comment

ACK - was able to re-produce it with Zelle in current master and it was fixed in this PR.

@ripcurlx

This comment has been minimized.

Copy link
Member

commented May 6, 2019

☝️ Just improved layout of Zelle buyer form on the way to prevent scrolling

@ripcurlx ripcurlx merged commit 5b70769 into bisq-network:master May 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sqrrm

sqrrm approved these changes May 6, 2019

Copy link
Member

left a comment

ACK

Looks good

@ripcurlx

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Just found a little detail that needed to be changed. Translations and references of March 15th needs to be changed to March 1st. And so the release build starts again 😉

@sqrrm sqrrm referenced this pull request May 7, 2019

Open

Cycle 1 #282

@ManfredKarrer ManfredKarrer deleted the ManfredKarrer:allow-seller-to-take-any-offers branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.