Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dao sync text after restore from seed #2836

Conversation

Projects
None yet
2 participants
@devinbileck
Copy link
Member

commented May 16, 2019

After restoring from seed, the text shown under DAO /
BSQ Wallet / Transactions displays an incorrect progress - the numbers
are swapped. For example:
"Awaiting blocks... Verified 575,868 blocks out of 554,857"

Normally we get the latest block height from BitcoinJ as the
target height, and we request BSQ blocks from seed nodes up to latest
block.

But when restoring from seed, we receive the latest block height
from the seed nodes while BitcoinJ has not received all blocks yet and
is still syncing.

Fixes #2825

devinbileck added some commits May 16, 2019

Fix DAO synchronization text after restore from seed
After restoring from seed, the text shown under DAO /
BSQ Wallet / Transactions displays an incorrect progress - the numbers
are swapped. For example:
"Awaiting blocks... Verified 575,868 blocks out of 554,857"

Normally we get the latest block height from BitcoinJ as the
target height, and we request BSQ blocks from seed nodes up to latest
block.

But when restoring from seed, we receive the latest block height
from the seed nodes while BitcoinJ has not received all blocks yet and
is still syncing.

Fixes #2825
Update status text when BTC sync in progress
Changes the status text when BTC sync in progress from:
Synchronized with Bitcoin Mainnet (using Tor): 10.00%

to:
Synchronizing with Bitcoin Mainnet (using Tor): 10.00%

@devinbileck devinbileck requested review from ripcurlx and sqrrm as code owners May 16, 2019

@ManfredKarrer
Copy link
Member

left a comment

utACK

@ManfredKarrer ManfredKarrer merged commit 7d7da05 into bisq-network:master May 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:fix-dao-sync-text-after-restore-from-seed branch May 16, 2019

@devinbileck devinbileck referenced this pull request Jun 7, 2019

Closed

For Cycle 2 #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.