Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confirm lockup transaction prompt showing incorrect estimated time #2844

Merged
merged 2 commits into from May 18, 2019

Conversation

Projects
None yet
2 participants
@devinbileck
Copy link
Member

commented May 17, 2019

When attempting to lock up a bond, the confirmation prompt was showing an incorrect estimated time:
image

This PR fixes the estimated time:
image

devinbileck added some commits May 17, 2019

Fix formatDurationAsWords when duration is multiple of 10 days
When the duration is a multiple of 10 days (e.g. 110 days) and not
showing zero values, it was incorrectly formatting it as "11" rather
than "110 days".

@devinbileck devinbileck requested review from ripcurlx and sqrrm as code owners May 17, 2019

@sqrrm

sqrrm approved these changes May 18, 2019

Copy link
Member

left a comment

utACK

@sqrrm sqrrm merged commit 2591ddd into bisq-network:master May 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@devinbileck devinbileck deleted the devinbileck:fix-formatDurationAsWords branch May 19, 2019

@sqrrm sqrrm referenced this pull request Jun 7, 2019

Closed

Cycle 2 #293

@devinbileck devinbileck referenced this pull request Jun 7, 2019

Closed

For Cycle 2 #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.