Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox to hide extreme offers in chart #2884

Merged
merged 4 commits into from Jul 12, 2019

Conversation

@sqrrm
Copy link
Member

commented Jun 14, 2019

No description provided.

@sqrrm sqrrm requested a review from ripcurlx Jun 14, 2019

@mrosseel

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

since no issue is linked I'll comment here, is this the final solution? Other solutions would be a log scale, or an algorithm to cut off offers which are too far away. Available to brain-storm that algorithm ;)

@sqrrm

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

@mrosseel Not much thought went into this. I just got annoyed with the BSQ market chart being unusable. This solution hides the extreme offers from the chart (more than a factor 5 from the best offers). I don't really want to put much more work into this right now, which the log scale solution probably would be.

@HarryMacfinned

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

Thanks @sqrrm ,
btw, this extreme offers seems really here to intentionally damage.
Sometimes it briefly disappears ... and some hours later they are here again.

@ripcurlx
Copy link
Member

left a comment

I personally would just remove the extremes without adding new controls as I don't think there is a use case where someone wants to have this kind of display. If we find time in the future to adapt to a logarithmic scale or similar we can just adapt the code again. Besides that ACK.

@sqrrm

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

Removed the checkbox. There is no indication that some offers might not be displayed in the chart now, but I suppose that's ok, it's about usability, not correctness.

@ripcurlx

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Removed the checkbox. There is no indication that some offers might not be displayed in the chart now, but I suppose that's ok, it's about usability, not correctness.

Yes, I understand your concerns, but we had a similar solution in place before (only display the best offers at all), so I think it is OK if we continue to iterate on this over time.

@ripcurlx
Copy link
Member

left a comment

Please have a look at my comments.

@@ -53,6 +53,7 @@ shared.oneOffer=offer
shared.multipleOffers=offers
shared.Offer=Offer
shared.openOffers=open offers
shared.hideExtremes=Hide extremes

This comment has been minimized.

Copy link
@ripcurlx

ripcurlx Jun 21, 2019

Member

Please remove the translation as well

@@ -146,14 +147,20 @@ public OfferBookChartView(OfferBookChartViewModel model, Navigation navigation,
public void initialize() {
createListener();

// Header with currency combobox and checkbox to show extreme values
GridPane topGrid = new GridPane();

This comment has been minimized.

Copy link
@ripcurlx

ripcurlx Jun 21, 2019

Member

Please also remove the additional GridPane again, so we don't use more containers as necessary.

@sqrrm

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

Removed all the extras except for the column option to a checkbox in FormBuilder.

@sqrrm sqrrm referenced this pull request Jul 9, 2019

@ripcurlx ripcurlx merged commit 3b915a3 into bisq-network:master Jul 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sqrrm sqrrm referenced this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.