Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late vote reveal handling #2888

Merged
merged 3 commits into from Jun 19, 2019

Conversation

@sqrrm
Copy link
Member

commented Jun 15, 2019

Vote reveal has to be published to complete the vote process even after the reveal phase. To indicate votes I added an indication that votes were not counted in result
image

Also added text to show failed votes in proposaldisplay
image

sqrrm added some commits Jun 15, 2019

@sqrrm sqrrm requested a review from ripcurlx as a code owner Jun 15, 2019

@sqrrm sqrrm requested a review from devinbileck Jun 15, 2019

@devinbileck
Copy link
Member

left a comment

I am encountering a display issue with this new indicator. When initially clicking on a prior voting cycle for which I successfully published the vote reveal, it is showing this new icon indicating it wasn't counted:
image

And clicking on it to bring up the details shows my vote was not included:
image

But viewing the individual votes shows each vote:
image

But when clicking on the current cycle and back to the prior cycle resolves it:
image

@sqrrm

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

@devinbileck Good find. It was the vote inclusion check that was wrong. Now fixed.

@devinbileck

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

That fixed it.

However, I am now noticing if I had ignored a proposal and my vote is not included, the ignored proposal is not shown in the results for the prior cycle, but the ones that I attempted to vote upon do show up.

As seen in this screenshot, Bob (bottom) made all the proposals and remained online and published his vote reveal tx, while Alice (top) went offline after the blind vote. Alice ignored the BTC maker fee proposal and it is not shown for her.
image

I haven't yet determined if this is related to this change or not.

@devinbileck

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

My above mentioned issue is not related to this change. I tested on master and had the same behaviour. In fact after restarting Bob's client, the ignored proposals no longer showed up. Not sure if related but I seem to have a conflict with my DAO state as it is not in sync with my seed. Not sure why at this point.

@sqrrm

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

It's pretty strange to lose a proposal, once received the client should save it. If you can reproduce that issue it would be good to take a look at. Might cause some issue during voting if it splits the votes.

@devinbileck

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

Agreed. I will see if I can reproduce it.

@devinbileck
Copy link
Member

left a comment

ACK

@sqrrm sqrrm merged commit 386209b into bisq-network:master Jun 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devinbileck devinbileck referenced this pull request Jul 8, 2019
@sqrrm sqrrm referenced this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.