Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for initialized wallet before processing dispute msgs, fix #2914 #2915

Merged
merged 2 commits into from Jun 24, 2019

Conversation

@sqrrm
Copy link
Member

commented Jun 23, 2019

No description provided.

@sqrrm sqrrm requested review from ripcurlx and devinbileck Jun 23, 2019

@devinbileck
Copy link
Member

left a comment

utACK

// In particular it's not possible to complete the signing of a dispute payout
// by an encrypted wallet until after it's been decrypted.
if (!servicesInitialized) {
return;

This comment has been minimized.

Copy link
@devinbileck

devinbileck Jun 24, 2019

Member

Just wondering if it would make more sense to put this check in tryApplyMessages? Since it appears to be the only caller of applyMessages and has an additional check.

This comment has been minimized.

Copy link
@sqrrm

sqrrm Jun 24, 2019

Author Member

I moved to the readiness check, looks much more reasonable, thanks.

This comment has been minimized.

Copy link
@sqrrm

sqrrm Jun 24, 2019

Author Member

Please ack again if it looks good.

@devinbileck
Copy link
Member

left a comment

utACK

@sqrrm sqrrm merged commit 08fe71a into bisq-network:master Jun 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devinbileck devinbileck referenced this pull request Jul 8, 2019
@sqrrm sqrrm referenced this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.