Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offer editing for low volume offers #2929

Merged
merged 1 commit into from Jul 2, 2019

Conversation

@a123b
Copy link
Contributor

commented Jun 29, 2019

A user on the forum had problems editing an offer:
https://bisq.community/t/alt-buy-offer-not-editable/7930

For very low volume offers, it can happen that the minimum buyer security
deposit by coin value is bigger than the maximum security deposit by
percentage of trade amount.
This caused the security deposit validity check in the offer editor to fail,
making it impossible to edit these offers.
This PR fixes the problem by setting the default percentage value to
the model instead of the calculated one in this specific case.

Fix offer editing for low volume offers
For very low volume offers, it can happen that the minimum buyer security
deposit by coin value is bigger than the maximum security deposit by
percentage of trade amount.
This caused the security deposit validity check in the offer editor to fail,
making it impossible to edit these offers.
This commit fixes the problem by setting the default percentage value to
the model instead of the calculated one in this specific case.

@a123b a123b requested review from ripcurlx and sqrrm as code owners Jun 29, 2019

@sqrrm
Copy link
Member

left a comment

NACK

While testing this seems to allow editing an offer but while editing the amount to buy is now forced to 1 BTC and grayed out. After editing and saving an offer I'm not able to edit it again.

@a123b

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

Strange... Can't reproduce it with my test offer.
If you send the details of the problematic offer I might take another look at it tomorrow.

@sqrrm

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Open offer as:
image
edit usd offer:
image
edit alt coin offer:
image

Attaching log but I don't think it's very interesting
issue_2929.log

Looks like the amount defaults to 1 BTC after editing. It might not be related to your fix though.

@a123b

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Oh, I think that's just the dev mode setting test values

@sqrrm

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Indeed, I don't think I tried editing an offer while testing before.

@sqrrm

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

ACK

Sorry, that was my bad with dev mode.

@sqrrm sqrrm merged commit 6e1f5ef into bisq-network:master Jul 2, 2019

@sqrrm sqrrm referenced this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.