Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor fixes #3045

Merged
merged 8 commits into from Aug 9, 2019

Conversation

@freimair
Copy link
Member

commented Aug 1, 2019

Finally got the monitor to state that is does not kill some of its metrics after a few hours.

Furthermore, I refactored the P2P Roundtriptime metric so it does not always report all seeds as offline if one or more of them takes too long to respond (the issue showed up just recently, seems that our seeds are under heavier load than they have been).

freimair added 7 commits Jul 18, 2019
@freimair freimair requested a review from ripcurlx as a code owner Aug 1, 2019
@freimair freimair referenced this pull request Aug 1, 2019
@christophsturm

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

would it be easy to add some unit tests to this pr?

@freimair

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

as the monitor is our least critical infrastructure I rather spend the time fixing stuff in Bisq itself.

@christophsturm

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

At some point in time there should be a rule that any change requires at least simple unit tests. And that time could as well be now.

@freimair

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

agreed. however, as we do not have the resources to do all and any testing in an instant we need to spend resources in thoughtful way

@sqrrm
sqrrm approved these changes Aug 9, 2019
Copy link
Member

left a comment

utACK

@sqrrm sqrrm merged commit b1ebe07 into bisq-network:master Aug 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@freimair freimair deleted the freimair:monitor-bsqblocks branch Aug 13, 2019
@sqrrm sqrrm referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.