Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render proper column headers and values for CSV exports; fix #3075 #3090

Conversation

@battleofwizards
Copy link
Contributor

commented Aug 14, 2019

When exporting to CSV, both portfolio/trades and funds/transactions were lacking the column headers.

Additionally, portfolio/trades colum values were outdated and not matching the intended export.

Both issues are fixed.

When exporting to CSV, both portfolio/trades and funds/transactions
were lacking the column headers.

Additionally, portfolio/trades colum values were outdated and
not matching the intended export.

Both issues are fixed.
Copy link
Member

left a comment

utACK

Copy link
Member

left a comment

Ack

@freimair freimair merged commit 9763753 into bisq-network:master Aug 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@freimair freimair referenced this pull request Aug 20, 2019
@battleofwizards battleofwizards referenced this pull request Sep 4, 2019
@battleofwizards battleofwizards deleted the battleofwizards:render-column-headers-in-csv-export branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.