Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto remove whitespace in the IBAN input field #3103

Merged

Conversation

@battleofwizards
Copy link
Contributor

commented Aug 17, 2019

When adding a payment account Bisq requires IBAN to be whitespace free.

It is annoying for the user to manually clean pasted IBAN of spaces. In online banking IBAN-s are usually displayed with spaces for better readability.

This commit auto-removes whitespace when user is leaving the input field, right before validation, effectively allowing to paste real world IBAN-s.

When adding a payment account Bisq requires IBAN to be whitespace free.

It is annoying for the user to manually clean pasted IBAN of spaces.
In online banking IBAN-s are usually displayed *with* spaces for
better readability.

This commit auto-removes whitespace when user is leaving the input
field, right before validation, effectively allowing to paste
real world IBAN-s.
@battleofwizards battleofwizards requested review from ripcurlx and sqrrm as code owners Aug 17, 2019
Copy link
Member

left a comment

ACK

@ripcurlx ripcurlx merged commit ab75db8 into bisq-network:master Aug 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@battleofwizards battleofwizards referenced this pull request Sep 4, 2019
@ripcurlx ripcurlx referenced this pull request Sep 6, 2019
@battleofwizards battleofwizards deleted the battleofwizards:auto-remove-whitespace-from-iban branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.