Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NullPointerException in ProposalsView #3118

Conversation

@devinbileck
Copy link
Member

commented Aug 21, 2019

When activating the ProposalsView, the table height is updated on the
user thread. Sometimes the scene is unavailable and causes a
NullPointerException. This should at least prevent the exception.

Fixes #2883 and #3116

When activating the ProposalsView, the table height is updated on the
user thread. Sometimes the scene is unavailable and causes a
NullPointerException. This should at least prevent the exception.

Fixes #2883 and #3116
@devinbileck devinbileck requested review from ripcurlx and sqrrm as code owners Aug 21, 2019
Copy link
Member

left a comment

utACK

@ripcurlx ripcurlx merged commit b1ddb07 into bisq-network:master Aug 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devinbileck devinbileck deleted the devinbileck:prevent-proposals-view-null-pointer-exception branch Aug 21, 2019
@ripcurlx ripcurlx referenced this pull request Sep 6, 2019
@devinbileck devinbileck referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.