Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in SearchComboBox (improve autocomplete) #3124

Merged

Conversation

@battleofwizards
Copy link
Contributor

commented Aug 21, 2019

Bisq's SearchComboBox implements a simple autocomplete. It is used on the "add new altcoin account" form.

This fixes the following bugs in the SearchComboBox:

  • no more dropdown flickering (fixed hide+show hack)
  • space key no longer resets the text input
  • unconfirmed changes no longer affect the form
  • empty list no longer renders empty dropdown

This PR is the first step towards using autocomplete more widely in the project. Once merged I will attempt to address #2712 (but can't promise anything).

Bisq's SearchComboBox implements a simple autocomplete. It is used
on the "add new altcoin account" form.

This fixes the following bugs in the SearchComboBox:

* no more dropdown flickering (fixed hide+show hack)
* space key no longer resets the text input
* unconfirmed changes no longer affect the form
* empty list no longer renders empty dropdown

This is a preparation step for using SearchComboBox more widely
in the project.
@battleofwizards battleofwizards requested review from ripcurlx and sqrrm as code owners Aug 21, 2019
Copy link
Member

left a comment

ACK - Just tested it and its looking good 👍

@ripcurlx ripcurlx merged commit 0d9d1bd into bisq-network:master Aug 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@battleofwizards battleofwizards referenced this pull request Sep 4, 2019
@ripcurlx ripcurlx referenced this pull request Sep 6, 2019
@battleofwizards battleofwizards deleted the battleofwizards:fix-dropdown-autocomplete-bugs branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.