Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase top navigation button text size for Japanese locale #3133

Merged
merged 2 commits into from Aug 25, 2019

Conversation

@wiz
Copy link
Member

commented Aug 23, 2019

Before / After screenshots
bisq1
bisq2

@wiz wiz requested review from ripcurlx and sqrrm as code owners Aug 23, 2019
@battleofwizards

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

Minor suggestion: consider renaming the .nav-button-large to .nav-button-for-japanese-locale.

The class name as it is now suggests some broader use or importance and so is misleading.

Of course, if other languages turn out to need this larger nav, the name may be further changed to be a bit more generic, like .nav-button-for-asian-locales.

Thanks!

Copy link
Member

left a comment

utACK

@wiz

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2019

@battleofwizards good point, I've changed it to -japanese, leaving it up to other CJK languages to tweak the font-size on their own

@sqrrm sqrrm merged commit 6273246 into bisq-network:master Aug 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wiz wiz deleted the wiz:japanese-nav-buttons branch Aug 28, 2019
@battleofwizards battleofwizards referenced this pull request Sep 4, 2019
@wiz wiz referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.