Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add average bsq price #3212

Merged

Conversation

@chimp1984
Copy link
Contributor

commented Sep 6, 2019

No description provided.

chimp1984 added 2 commits Sep 6, 2019
@chimp1984 chimp1984 requested review from ripcurlx and sqrrm as code owners Sep 6, 2019
@chimp1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

Screen Shot 2019-09-06 at 04 37 27

Copy link
Member

left a comment

Please only change stuff that actually changes code behavior. It is really cumbersome to check method signatures and whether they changed or not. Your suggestion contains 10+ method headers that have not changed functionally, but all of them are changes. Please revert those unnecessary changes now and in the future. Thanks!

@chimp1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@freimair I try to clean up classes I touch. As siad above appying the formatting rules should be mandatory anyway to all commits IMO.

@freimair

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

yes, applying formatting rules IS mandatory but only for new or functionally changed code. In the end, everything should be the same, however, it takes a lot more time reviewing changes that are no changes. So you might encounter longer times until stuff gets merged.

Copy link
Member

left a comment

Ack

aand we shall not forget to get these changes into master...

@freimair freimair referenced this pull request Sep 6, 2019
@ripcurlx

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Ack

aand we shall not forget to get these changes into master...

After the release I'll rebase and merge this branch into master anyways.

@ripcurlx ripcurlx merged commit 7c034a4 into bisq-network:release/v1.1.6 Sep 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chimp1984 chimp1984 deleted the chimp1984:add-average-bsq-price branch Sep 6, 2019
@chimp1984 chimp1984 referenced this pull request Sep 6, 2019
@ripcurlx ripcurlx referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.