Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bsq price trend indicator #3226

Merged

Conversation

@chimp1984
Copy link
Contributor

commented Sep 8, 2019

No description provided.

chimp1984 added 4 commits Sep 8, 2019
The average 30 days price is more relevant information than the small
different between average and median price. To add a second tuple of
both would be another option would overload the screen with not that
relevant information.

In a follow up commit we want to add an ip/down indication so see
price trend.

Fixes also handling of 0 values.
If average 30 days price is > av. 90 days price we show a green
arrow up, otherwise a red arrow down. If same we don't show an arrow.
@chimp1984 chimp1984 requested review from ripcurlx and sqrrm as code owners Sep 8, 2019
@chimp1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2019

The median price is not based on amount weight, so the average is considered more exact IMO.
This PR replaces the median 90 day price wioth the average 30 days and adds an indicator if price is going up or down.

Screen Shot 2019-09-08 at 12 02 18

Screen Shot 2019-09-08 at 12 03 48

Forgot to change back a small change to test directions...
@chimp1984 chimp1984 referenced this pull request Sep 8, 2019
@sqrrm
sqrrm approved these changes Sep 8, 2019
Copy link
Member

left a comment

utACK

The median is now gone, perhaps it would've been nice to keep it, but I have no real strong opinion there.

@chimp1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2019

perhaps it would've been nice to keep it, but I have no real strong opinion there.

I was alos wondering to make 2 lines, but I think its not worth it. Too much info weakens the important info.

@wiz

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

It's backwards, should be BTC/BSQ

Screen Shot 2019-09-09 at 10 38 18

@sqrrm sqrrm referenced this pull request Sep 9, 2019
Copy link
Member

left a comment

ACK

@ripcurlx ripcurlx merged commit bb806cf into bisq-network:release/v1.1.6 Sep 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chimp1984 chimp1984 deleted the chimp1984:add-bsq-price-trend-indicator branch Sep 10, 2019
@chimp1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

It's backwards, should be BTC/BSQ

No altcoins are displayed with Altcoin/BTC - not logical but the standard...

@ripcurlx ripcurlx referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.