Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing handling of mediator mailbox msg #3310

Conversation

@chimp1984
Copy link
Contributor

commented Sep 22, 2019

We have a bug with the handling of missing mailbox messaged from mediation result and the peers accept message (carrying the signature). This PR fixes that.

For testing shut down the other trade peer at each step after mediation gets closed.

  1. Mediation is opened
  2. Bob shutd down
  3. Alice accept result
  4. Alice shuts down
  5. Bob starts and accepts result
  6. Alice starts and sees the trade got closed
chimp1984 added 3 commits Sep 22, 2019
- Without that fix mediated payouts would only succeed if both users are
online.
We need to delay that call as we might get executed at startup after
mailbox messages are applied where we iterate over out pending trades.
The closeDisputedTrade method would remove that trade from the list
causing a ConcurrentModificationException.
To avoid that we delay for one render frame.
@chimp1984 chimp1984 requested review from ripcurlx and sqrrm as code owners Sep 22, 2019
Copy link
Member

left a comment

utACK

@ripcurlx ripcurlx merged commit 51d3179 into bisq-network:master Sep 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

ACK - found another small translation bug, that will be added to the hotfix as well.

@chimp1984 chimp1984 referenced this pull request Sep 23, 2019
@chimp1984 chimp1984 deleted the chimp1984:fix-missing-handling-of-mediator-mailbox-msg branch Sep 27, 2019
@ripcurlx ripcurlx referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.