Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proposal table hide when switching to another screen and back #3356

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@stejbac
Copy link
Contributor

stejbac commented Oct 3, 2019

Do not remove the proposals table when VoteResultView is deactivated, as the cycle selection which triggered its display is still active upon switching to another screen and back again. This fixes #3269.

Also remove a spurious GUIUtil.removeChildrenFromGridPaneRows call when a proposal result is selected, as it is no longer needed since switching from an inline votes table to a popup.

Do not remove the proposals table when VoteResultView is deactivated, as
the cycle selection which triggered its display is still active upon
switching to another screen and back again. This fixes #3269.

Also remove a spurious 'GUIUtil.removeChildrenFromGridPaneRows' call
when a proposal result is selected, as it is no longer needed since
switching from an inline votes table to a popup.
@stejbac stejbac requested review from ripcurlx and sqrrm as code owners Oct 3, 2019
Copy link
Member

freimair left a comment

Ack

@freimair freimair merged commit 1999cfb into bisq-network:master Nov 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@freimair freimair referenced this pull request Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.