Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BisqEnvironment - change type of ignoreLocalBtcNode to boolean #3434

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@lusarz
Copy link
Contributor

lusarz commented Oct 19, 2019

No description provided.

@lusarz lusarz requested a review from ripcurlx as a code owner Oct 19, 2019
Copy link
Member

freimair left a comment

can we have a

  --ignoreLocalBtcNode
        If set, a Bitcoin core node running locally will be ignored

instead of

  --ignoreLocalBtcNode=<value>
        If set to true a Bitcoin core node running locally will be ignored

while you are at it?

@lusarz lusarz force-pushed the lusarz:refactor-bisq-environment-5 branch from 4f79a1d to fe32649 Nov 3, 2019
@lusarz

This comment has been minimized.

Copy link
Contributor Author

lusarz commented Nov 3, 2019

Conflicts resolved.

I think we can do --ignoreLocalBtcNode instead of --ignoreLocalBtcNode=<value>, but we should consider situation when someone pass for example --ignoreLocalBtcNode=false. I propose to create dedicated issue for that and discuss it a bit there.

Copy link
Member

freimair left a comment

agreed.

Ack.

@freimair freimair merged commit 415aa10 into bisq-network:master Nov 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@freimair freimair referenced this pull request Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.