Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not commit delayedPayoutTx to avoid publishing at restart #3464

Conversation

@chimp1984
Copy link
Contributor

chimp1984 commented Oct 25, 2019

Fixes #3463

BitcoinJ publishes automatically committed transactions.
We committed it to the wallet to be able to access it later after a
restart. We stored the txId in Trade and used that to request the tx
from the wallet (as it was committed). Now we store the
bitcoin serialized bytes of the tx and do not commit the tx before
broadcasting it (if a trader opens refund agent ticket).

Fixes #3463

BitcoinJ publishes automatically committed transactions.
We committed it to the wallet to be able to access it later after a
restart. We stored the txId in Trade and used that to request the tx
from the wallet (as it was committed). Now we store the
bitcoin serialized bytes of the tx and do not commit the tx before
broadcasting it (if a trader opens refund agent ticket).
@chimp1984 chimp1984 requested a review from ripcurlx as a code owner Oct 25, 2019
@chimp1984 chimp1984 referenced this pull request Oct 25, 2019
Copy link
Member

ripcurlx left a comment

utACK

@ripcurlx ripcurlx merged commit e1c1dd8 into bisq-network:release/v1.2.0 Oct 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devinbileck

This comment has been minimized.

Copy link
Member

devinbileck commented Oct 25, 2019

I tested this and the original issue has been resolved.
However, I ran into a couple other issues that I am not sure if related, but I will enter separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.