Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BTC valuation popups #3539

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@devinbileck
Copy link
Member

devinbileck commented Nov 1, 2019

When hovering over the BTC balances, the popup was using the market
price based on the locale combined with the preferred currency as its
units. This lead to the situation where it could show a mismatch
between value and units.

Instead, use the market price based on the preferred currency.

Fixes #3515

When hovering over the BTC balances, the popup was using the market
price based on the locale combined with the preferred currency as its
units. This lead to the situation where it could show a mismatch
between value and units.

Instead, use the market price based on the preferred currency.

Fixes #3515
@devinbileck devinbileck requested review from ripcurlx and sqrrm as code owners Nov 1, 2019
Copy link
Member

freimair left a comment

Ack.

Although one has to restart the application in order to get a new preferred currency to work for the tooltip. Since one would not change the preferred currency on a regular basis I recon that is ok.

@freimair freimair merged commit 901cde0 into bisq-network:master Nov 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@freimair freimair referenced this pull request Nov 1, 2019
@devinbileck devinbileck deleted the devinbileck:fix-btc-valuation-popups branch Nov 2, 2019
@devinbileck devinbileck referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.