Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update seednode config to increase resource limits for v1.2 #3545
Sorry if I missed any discussion, but what is the reasoning for this and what is the chart illustrating? Based on that chart, it doesn't look like all the memory is being consumed?
If this increase is truly required, then we will need to increase the minimum requirements: https://docs.bisq.network/exchange/howto/run-seednode.html#system-requirements-for-hosting-machine
Ah ok. I believe other seed nodes are using more modest parameters (30 max connections) which is why I assume you are the only/first to encounter this.
In any case, I think we should either (1) adjust these "default" parameters (Xms, Xmx, maxmemory, maxconnections) to be more modest and capable of meeting the stated minimum requirements, or (2) increase the minimum requirements and ensure all seednode operators update their configuration.
@wiz At 1.2.0/1.2.1 we have an issue with the trade statistics which caused a lot of resources as each node got delivered 7-9 MB of data. That was fixed with the branch I provided and now memory consumption should be back to normal. I am not aware of any reason why v1.2 should consume more ram as before.
There was the issue that risq (as discused with @bodymindarts and you) made requests which caused seeds to respond with about 10 MB of data (all accountage witness data and all trade stats) but those have been about 10 requests a day so that should not have caused permanent memory/cpu pressure, but could have been the cause for an OOM error as well. I have not tested the performance cost here but I know from BSQ blocks that requesting so much datat was very heavy (took about 30 sec for 12MB data).
With a 90 days history it seems we got higher memory consumption around the 15th of September. That was around 1.1.6 release. But different seeds have different patterns, but all had lower memory consumption back in August. So some changes in that time frame has caused more pressure. 1.1.6. introduces traders chat, so that produces more mailbox messages and currently there are about 600 which is rather high, but probably caused by the update mess....
We should monitor those data more closely and alert devs in case we see some increases....
I will try to look into code changes in 1.1.6. which might be responsible for those changes.