Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for empty validation #3573

Merged

Conversation

@beingindot
Copy link
Contributor

beingindot commented Nov 7, 2019

This commit is for github issue
fixes #3458
fixes #3459

Added empty validation check added for moneybeam and national bank transfer payment methods

@beingindot beingindot requested review from ripcurlx and sqrrm as code owners Nov 7, 2019
@beingindot beingindot mentioned this pull request Nov 8, 2019
Copy link
Contributor

chimp1984 left a comment

utACK

@beingindot beingindot force-pushed the beingindot:account_validate_mg_nationalbank branch from 31645f5 to 133d40a Nov 12, 2019
@beingindot

This comment has been minimized.

Copy link
Contributor Author

beingindot commented Nov 12, 2019

Just pushed same commit as signed commit(included code reformat).

Copy link
Member

ripcurlx left a comment

NACK - Just move the one trim of the setAccountNameWithString to the PaymentMethodForm and utACk for the rest.

This commit is for github issue #3458 and #3459
check added for moneybeam and national bank transfer
@beingindot beingindot force-pushed the beingindot:account_validate_mg_nationalbank branch from 133d40a to 755ca19 Nov 13, 2019
@beingindot

This comment has been minimized.

Copy link
Contributor Author

beingindot commented Nov 13, 2019

@ripcurlx Have added the review changes. Pls check.

Copy link
Member

freimair left a comment

utAck

@freimair freimair mentioned this pull request Nov 13, 2019
@ripcurlx ripcurlx merged commit 459646a into bisq-network:master Nov 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@beingindot beingindot mentioned this pull request Dec 9, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.