Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account validation #3575

Merged
merged 1 commit into from Nov 14, 2019
Merged

Account validation #3575

merged 1 commit into from Nov 14, 2019

Conversation

@beingindot
Copy link
Contributor

beingindot commented Nov 7, 2019

#3460

Added empty check validation for
popmoney/uphold/revolut/zelle

bank forms already have required changes with previous PR.

@beingindot beingindot requested review from ripcurlx and sqrrm as code owners Nov 7, 2019
@beingindot beingindot mentioned this pull request Nov 8, 2019
Copy link
Contributor

chimp1984 left a comment

utACK

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Nov 13, 2019

@beingindot Also all your commits need signing and you need to resolve the conflict now that your other PR got merged.

@beingindot beingindot force-pushed the beingindot:account_validation branch from c74c08c to 4432d80 Nov 14, 2019
@beingindot

This comment has been minimized.

Copy link
Contributor Author

beingindot commented Nov 14, 2019

@ripcurlx Resolved conflicts and included changes. pls check.

@ripcurlx ripcurlx merged commit 7e08d66 into bisq-network:master Nov 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@beingindot beingindot mentioned this pull request Dec 9, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.