Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test when there are spaces in the project path #3578

Merged

Conversation

@stejbac
Copy link
Contributor

stejbac commented Nov 8, 2019

Use URI.getPath() rather than URL.getFile() to get the absolute path of a test resource, since the latter fails to perform URL decoding. This breaks the tests when the project root contain chars needing %-encoding.

This fixes errors of the following form in (BisqInstallerTest) verifySignature:

java.io.FileNotFoundException: /home/steven/Documents/Java%20Projects/bisq/desktop/build/resources/test/downloadUpdate/F379A1C6.asc (No such file or directory)

@stejbac stejbac requested review from ripcurlx and sqrrm as code owners Nov 8, 2019
Copy link
Member

freimair left a comment

utAck

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Nov 8, 2019

Use URI.getPath() rather than URL.getFile() to get the absolute path of
a test resource, since the latter fails to perform URL decoding. This
breaks the tests when the project root contain chars needing %-encoding.
@stejbac stejbac force-pushed the stejbac:support-spaces-in-project-path branch from 11860c5 to e20f841 Nov 9, 2019
@stejbac

This comment has been minimized.

Copy link
Contributor Author

stejbac commented Nov 9, 2019

I've now added a GPG key to Github and amended the commit to include a signature.

Copy link
Member

freimair left a comment

Ack

@freimair freimair merged commit 87f67f7 into bisq-network:master Nov 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@freimair freimair mentioned this pull request Nov 11, 2019
@stejbac stejbac mentioned this pull request Dec 13, 2019
@stejbac stejbac mentioned this pull request Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.