Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating trading instructions for XMR (Monero) #3596

Merged
merged 2 commits into from Nov 14, 2019

Conversation

@rating89us
Copy link
Contributor

rating89us commented Nov 11, 2019

Prove payments:

  • clarifying that the official wallets (Monero GUI or CLI) are NOT required to send XMR, since user can use some alternative wallets (desktop: MyMonero, Exodus / mobile: Cake Wallet, MyMonero, Monerujo) that provide the information required to prove a payment (transaction key, transaction ID and destination address). This information is not provided by the remaining desktop and mobile wallets that currently support Monero, but since they could provide it in the future, I kept the warning about using other wallets different from the previously mentioned.
  • listing Monero GUI as first option (for most users), and CLI as second option (for advanced users)
  • using "transaction ID", which is used in official wallets, and keeping "transaction hash" as synonymous, which is used in XMR checktx tool
  • using "transaction key", which is used in official wallets, and adding synonymous like "Secret key", which is used in MyMonero wallet
  • adding "destination address" and keeping "recipient's address" as synonymous
  • renaming History tab to Transactions tab in Monero GUI
  • adding "save recipient address" option must be enabled in Cake Wallet settings
  • add warning to never delete or restore a Monero wallet before a Bisq trade is completed (since the transaction key and the destination address are stored in the Monero wallet software, and they cannot be recovered in the Monero blockchain)

Check payments:

More info:

Prove payments:
- clarifying that the official wallets (Monero GUI or CLI) are NOT required to send XMR, since user can use some alternative wallets (desktop: MyMonero, Exodus / mobile: Cake Wallet, MyMonero, Monerujo) that provide the information required to prove a payment (transaction key, transaction ID and destination address). This information is not provided by the remaining desktop and mobile wallets that currently support Monero, but since they could provide it in the future, I kept the warning about using other wallets different from the previously mentioned.
- listing Monero GUI as first option (for most users), and CLI as second option (for advanced users)
- renaming "transaction hash" to "transaction ID", which is used in official wallets
- renaming "tx private key" to "transaction key", which is used in official wallets
- adding "Secret key" as synonymous for "transaction key" (used in MyMonero wallet)
- adding "destination address" and keeping  "recipient's address" as synonymous
- renaming History tab to Transactions tab in Monero GUI
- adding "save recipient address" option must be enabled in Cake Wallet settings

Check payments:
- adding Monero GUI must be in Advanced mode
- adding Monero GUI verification must be done in Check Transaction section of Prove/check page
- adding parameters TXID TXKEY ADDRESS to the command check_tx_key in Monero CLI, as instructions in (https://www.getmonero.org/resources/user-guides/prove-payment.html)
- adding Explore Monero website (https://www.exploremonero.com/receipt) as alternative to verify payments
- removing payment ID instructions (it is being deprecated at the end of November in v0.15)

More info:
- directing to subreddit Monero support (https://www.reddit.com/r/monerosupport/), which is actively maintained, instead of Monero forum (https://forum.getmonero.org).
@rating89us rating89us requested a review from ripcurlx as a code owner Nov 11, 2019
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Nov 11, 2019

@niyid @woodser Could you give an ACK if this Monero info update is correct?

@niyid

This comment has been minimized.

Copy link
Contributor

niyid commented Nov 11, 2019

@niyid @woodser Could you give an ACK if this Monero info update is correct?

OK. @woodser ?

Regards.

@woodser

This comment has been minimized.

Copy link

woodser commented Nov 13, 2019

Looks good to me.

…Monero to improve readability
@rating89us rating89us requested a review from sqrrm as a code owner Nov 14, 2019
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Nov 14, 2019

@rating89us I had to extend your PR to make the content fit within our Popup. It exceeded the max character length we were supporting until now. I changed the window width for Monero and extended the max allowed character length.
Before
Bildschirmfoto 2019-11-14 um 15 07 05
After
Bildschirmfoto 2019-11-14 um 15 22 00

@rating89us

This comment has been minimized.

Copy link
Contributor Author

rating89us commented Nov 14, 2019

Looks good to me.

Copy link
Member

ripcurlx left a comment

ACK

@ripcurlx ripcurlx merged commit 21b76cb into bisq-network:master Nov 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.