Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added padding for flowpane to resolve moneygram save issue. #3600

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@beingindot
Copy link
Contributor

beingindot commented Nov 12, 2019

For #3598

Basically flowpane is hiding email label, hence we could not save. so
@ripcurlx suggested this workaround fix for immeidate push.

@beingindot beingindot requested review from ripcurlx and sqrrm as code owners Nov 12, 2019
Copy link
Member

ripcurlx left a comment

ACK NACK - as the commit needs to be signed.

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Nov 12, 2019

@beingindot ACK on the code change - NACK- you need to sign your commits

@ripcurlx ripcurlx dismissed their stale review Nov 12, 2019

Missed the non-signed commit

Copy link
Member

ripcurlx left a comment

NACK - as the commit needs to be signed

@beingindot beingindot force-pushed the beingindot:moneygram_issue branch from 58842c2 to a132698 Nov 12, 2019
@ripcurlx ripcurlx merged commit d00179c into bisq-network:master Nov 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@beingindot beingindot mentioned this pull request Dec 9, 2019
@ripcurlx ripcurlx mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.